-
Notifications
You must be signed in to change notification settings - Fork 774
[version.syn] FTMs for freestanding features should be freestanding #7819
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
See also LWG4126. As there's already an accepted LWG issue, I want the changes here to be handled editorially. |
If that is the case, then maybe all of P2976 does not discuss FTM changes much, only adding |
Probably yes except for IIUC that the following FTMs should also be freestanding. Some of them should have been so when adopting LWG4126, but I overlooked them.
|
03a4c7f
to
40317a6
Compare
40317a6
to
c176fba
Compare
Changes done. |
c176fba
to
f74321f
Compare
I don't think this is editorial. Please file an LWG issue if you think the status quo is defective. |
I'm hoping this helps with any LWG issues that get filed... LWG4189 didn't add most of , P1642R11 added most of ranges. LWG4189 added cache_latest and then changed the editorial style, using "// mostly freestanding" at the header level instead of dozens of "// freestanding" at the declaration level. I think
These also seem plausible, just be sure to audit the originating paper to ensure that there weren't other hosted facilities in the paper
Also, apologies for not doing the audit of existing feature test macros with P2976R1. |
LWG4189 (accepted in Hagenberg via #7660) added nearly the entire
<ranges>
header to freestanding. However, the only feature-test macro being added to freestanding is__cpp_lib_ranges_cache_latest
, which seems weird, sinceviews::enumerate
is also added to freestanding following the blanket comment strategy, but its feature-test macro remains not in freestanding.I don't think
views::enumerate
andviews::cache_latest
should be treated differently here, so this PR tries to sync the status of their FTMs.Another issue is
reserve_hint
(#7698). The paper itself does not state clearly whether__cpp_lib_ranges_reserve_hint
should be in freestanding or not, but given thatranges::reserve_hint
itself is in freestanding, I think the FTM should also be in too.